Cover Image and Encoding bug fixes #21
Conversation
|
@1234filip Thanks for the contribution. Two separate pull requests for the encoding issues and the cover art feature would be appreciated as I'm not inclined to merge these changes to the main branch together. Especially in the case of the cover art feature, which would require time for updating the read.me and familiarity with in order to provide support. |
I'll make a separate request for the encoding issue but I can't decouple them as the cover art feature isn't possible without the encoding one. |
I decided to add the functionality to write a cover image beside the track information file.
Also, the encoding of the parser was wrong so I fixed that, though it is only a temporary fix. It should be
utf-16-beand notlatinbut then it throws some errors. I would suggest just manipulating the raw bytes and decoding only when necessary. Now it also handles stuff likeč,žand Chinese characters properly.I also added a gitignore because some people use
pipenv.Also, I added some missing packages to
requirements.txt.I know these things should be separate pull requests but I couldn't be bothered.
P.S. The code is very messy when you put everything into one file. I would suggest breaking it up before it becomes too massive.